iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/amdkfd: Fix iterator used outside loop in 'kfd_add_peer_prop()'

Browse Source 
Fix the following about iterator use:
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1456 kfd_add_peer_prop() warn: iterator used outside loop: 'iolink3'

Cc: Felix Kuehling <Felix.Kuehling@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Srinivasan Shanmugam
2023-12-29 15:07:09 +05:30
committed by Alex Deucher
parent bf2ad4fb8a
commit b1a428b45d
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/gpu/drm/amd/amdkfd/kfd_topology.c
View File

@@ -1452,17 +1452,19 @@ static int kfd_add_peer_prop(struct kfd_topology_device *kdev,
/* CPU->CPU link*/ /* CPU->CPU link*/
cpu_dev = kfd_topology_device_by_proximity_domain(iolink1->node_to); cpu_dev = kfd_topology_device_by_proximity_domain(iolink1->node_to);
if (cpu_dev) { if (cpu_dev) {
list_for_each_entry(iolink3, &cpu_dev->io_link_props, list) list_for_each_entry(iolink3, &cpu_dev->io_link_props, list) {
if (iolink3->node_to == iolink2->node_to) if (iolink3->node_to != iolink2->node_to)
break; continue;
props->weight += iolink3->weight; props->weight += iolink3->weight;
props->min_latency += iolink3->min_latency; props->min_latency += iolink3->min_latency;
props->max_latency += iolink3->max_latency; props->max_latency += iolink3->max_latency;
props->min_bandwidth = min(props->min_bandwidth, props->min_bandwidth = min(props->min_bandwidth,
iolink3->min_bandwidth); iolink3->min_bandwidth);
props->max_bandwidth = min(props->max_bandwidth, props->max_bandwidth = min(props->max_bandwidth,
iolink3->max_bandwidth); iolink3->max_bandwidth);
break;
}
} else { } else {
WARN(1, "CPU node not found"); WARN(1, "CPU node not found");
} }