iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: qla2xxx: Complain if a command is released that is owned by the firmware

Browse Source 
The previous patch guarantees that a command is only released after the
firmware has finished processing it. Hence complain if a command is
released that is owned by the firmware.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Cc: Giridhar Malavali <gmalavali@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bart Van Assche 2019-04-17 14:44:30 -07:00 committed by Martin K. Petersen
parent aefed3e554
commit b1e261d4a4
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/scsi/qla2xxx/tcm_qla2xxx.c
View File

@ -320,7 +320,6 @@ static int tcm_qla2xxx_check_stop_free(struct se_cmd *se_cmd)
static void tcm_qla2xxx_release_cmd(struct se_cmd *se_cmd) static void tcm_qla2xxx_release_cmd(struct se_cmd *se_cmd)
{ {
struct qla_tgt_cmd *cmd; struct qla_tgt_cmd *cmd;
unsigned long flags;
if (se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB) { if (se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB) {
struct qla_tgt_mgmt_cmd *mcmd = container_of(se_cmd, struct qla_tgt_mgmt_cmd *mcmd = container_of(se_cmd,
@ -330,14 +329,10 @@ static void tcm_qla2xxx_release_cmd(struct se_cmd *se_cmd)
} }
cmd = container_of(se_cmd, struct qla_tgt_cmd, se_cmd); cmd = container_of(se_cmd, struct qla_tgt_cmd, se_cmd);
spin_lock_irqsave(&cmd->cmd_lock, flags); if (WARN_ON(cmd->cmd_sent_to_fw))
if (cmd->cmd_sent_to_fw) { return;
cmd->released = 1;
spin_unlock_irqrestore(&cmd->cmd_lock, flags);
} else {
spin_unlock_irqrestore(&cmd->cmd_lock, flags);
qlt_free_cmd(cmd); qlt_free_cmd(cmd);
}
} }
static void tcm_qla2xxx_release_session(struct kref *kref) static void tcm_qla2xxx_release_session(struct kref *kref)