iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: stm32: fix transmit_chars when tx is stopped

Browse Source 
[ Upstream commit b83b957c91f68e53f0dc596e129e8305761f2a32 ]

Disables the tx irq  when the transmission is ended and updates stop_tx
conditions for code cleanup.

Fixes: 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver")
Signed-off-by: Erwan Le Ray <erwan.leray@st.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Erwan Le Ray 2019-05-21 17:45:44 +02:00 committed by Greg Kroah-Hartman
parent b55ca259c2
commit b2af35a8ab
1 changed files with 3 additions and 8 deletions

11
drivers/tty/serial/stm32-usart.c

@ -293,13 +293,8 @@ static void stm32_transmit_chars(struct uart_port *port)
return;
}
if (uart_tx_stopped(port)) {
stm32_stop_tx(port);
return;
}
if (uart_circ_empty(xmit)) {
stm32_stop_tx(port);
if (uart_circ_empty(xmit) || uart_tx_stopped(port)) {
stm32_clr_bits(port, ofs->cr1, USART_CR1_TXEIE);
return;
}
@ -312,7 +307,7 @@ static void stm32_transmit_chars(struct uart_port *port)
uart_write_wakeup(port);
if (uart_circ_empty(xmit))
stm32_stop_tx(port);
stm32_clr_bits(port, ofs->cr1, USART_CR1_TXEIE);
}
static irqreturn_t stm32_interrupt(int irq, void *ptr)