iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

IB/mlx4: Rework special QP creation error path

Browse Source 
The special QP creation error path relies on offset_of(struct mlx4_ib_sqp,
qp) == 0. Remove this assumption because that makes the QP creation
code easier to understand.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Yishai Hadas <yishaih@mellanox.com>
Reviewed-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Bart Van Assche 2016-11-14 08:44:11 -08:00 committed by Doug Ledford
parent e98172462f
commit b42dde478b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/infiniband/hw/mlx4/qp.c
View File

@ -644,7 +644,7 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd,
int qpn; int qpn;
int err; int err;
struct ib_qp_cap backup_cap; struct ib_qp_cap backup_cap;
struct mlx4_ib_sqp *sqp; struct mlx4_ib_sqp *sqp = NULL;
struct mlx4_ib_qp *qp; struct mlx4_ib_qp *qp;
enum mlx4_ib_qp_type qp_type = (enum mlx4_ib_qp_type) init_attr->qp_type; enum mlx4_ib_qp_type qp_type = (enum mlx4_ib_qp_type) init_attr->qp_type;
struct mlx4_ib_cq *mcq; struct mlx4_ib_cq *mcq;
@ -933,7 +933,9 @@ err_db:
mlx4_db_free(dev->dev, &qp->db); mlx4_db_free(dev->dev, &qp->db);
err: err:
if (!*caller_qp) if (sqp)
kfree(sqp);
else if (!*caller_qp)
kfree(qp); kfree(qp);
return err; return err;
} }