proc: stop using BKL
There are four BKL users in proc: de_put(), proc_lookup_de(), proc_readdir_de(), proc_root_readdir(), 1) de_put() ----------- de_put() is classic atomic_dec_and_test() refcount wrapper -- no BKL needed. BKL doesn't matter to possible refcount leak as well. 2) proc_lookup_de() ------------------- Walking PDE list is protected by proc_subdir_lock(), proc_get_inode() is potentially blocking, all callers of proc_lookup_de() eventually end up from ->lookup hooks which is protected by directory's ->i_mutex -- BKL doesn't protect anything. 3) proc_readdir_de() -------------------- "." and ".." part doesn't need BKL, walking PDE list is under proc_subdir_lock, calling filldir callback is potentially blocking because it writes to luserspace. All proc_readdir_de() callers eventually come from ->readdir hook which is under directory's ->i_mutex -- BKL doesn't protect anything. 4) proc_root_readdir_de() ------------------------- proc_root_readdir_de is ->readdir hook, see (3). Since readdir hooks doesn't use BKL anymore, switch to generic_file_llseek, since it also takes directory's i_mutex. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
This commit is contained in:
@ -35,16 +35,13 @@ struct proc_dir_entry *de_get(struct proc_dir_entry *de)
|
||||
*/
|
||||
void de_put(struct proc_dir_entry *de)
|
||||
{
|
||||
lock_kernel();
|
||||
if (!atomic_read(&de->count)) {
|
||||
printk("de_put: entry %s already free!\n", de->name);
|
||||
unlock_kernel();
|
||||
return;
|
||||
}
|
||||
|
||||
if (atomic_dec_and_test(&de->count))
|
||||
free_proc_entry(de);
|
||||
unlock_kernel();
|
||||
}
|
||||
|
||||
/*
|
||||
|
Reference in New Issue
Block a user