iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: caif: fix memory leak in caif_device_notify

Browse Source 
In case of caif_enroll_dev() fail, allocated
link_support won't be assigned to the corresponding
structure. So simply free allocated pointer in case
of error

Fixes: 7c18d2205ea7 ("caif: Restructure how link caif link layer enroll")
Cc: stable@vger.kernel.org
Reported-and-tested-by: syzbot+7ec324747ce876a29db6@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pavel Skripkin 2021-06-03 19:39:11 +03:00 committed by David S. Miller
parent a2805dca51
commit b53558a950
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/caif/caif_dev.c
View File

@ -370,6 +370,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
struct cflayer *layer, *link_support; struct cflayer *layer, *link_support;
int head_room = 0; int head_room = 0;
struct caif_device_entry_list *caifdevs; struct caif_device_entry_list *caifdevs;
int res;
cfg = get_cfcnfg(dev_net(dev)); cfg = get_cfcnfg(dev_net(dev));
caifdevs = caif_device_list(dev_net(dev)); caifdevs = caif_device_list(dev_net(dev));
@ -395,8 +396,10 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
break; break;
} }
} }
caif_enroll_dev(dev, caifdev, link_support, head_room, res = caif_enroll_dev(dev, caifdev, link_support, head_room,
&layer, NULL); &layer, NULL);
if (res)
cfserl_release(link_support);
caifdev->flowctrl = dev_flowctrl; caifdev->flowctrl = dev_flowctrl;
break; break;