iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests/powerpc: Fix matrix multiply assist test

Browse Source 
[ Upstream commit cd1e64935f79e31d666172c52c951ca97152b783 ]

The ISA states: "when ACC[i] contains defined data, the contents of VSRs
4×i to 4×i+3 are undefined until either a VSX Move From ACC instruction
is used to copy the contents of ACC[i] to VSRs 4×i to 4×i+3 or some other
instruction directly writes to one of these VSRs." We aren't doing this.

This test only works on Power10 because the hardware implementation
happens to map ACC0 to VSRs 0-3, but will fail on any other implementation
that doesn't do this. So add xxmfacc between writing to the accumulator
and accessing the VSRs.

Fixes: 3527e1ab9a79 ("selftests/powerpc: Add matrix multiply assist (MMA) test")
Signed-off-by: Rashmica Gupta <rashmica@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220617043935.428083-1-rashmica@linux.ibm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Rashmica Gupta 2022-06-17 14:39:35 +10:00 committed by Greg Kroah-Hartman
parent f35c7f506f
commit b5de92e1bb
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/testing/selftests/powerpc/math/mma.S
View File

@ -20,6 +20,9 @@ test_mma:
/* xvi16ger2s */
.long 0xec042958
/* Deprime the accumulator - xxmfacc 0 */
.long 0x7c000162
/* Store result in image passed in r5 */
stxvw4x 0,0,5
addi 5,5,16