iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvme-pci: fix doorbell buffer value endianness

Browse Source 
When using shadow doorbells, the event index and the doorbell values are
written to host memory. Prior to this patch, the values written would
erroneously be written in host endianness. This causes trouble on
big-endian platforms. Fix this by adding missing endian conversions.

This issue was noticed by Guenter while testing various big-endian
platforms under QEMU[1]. A similar fix required for hw/nvme in QEMU is
up for review as well[2].

  [1]: https://lore.kernel.org/qemu-devel/20221209110022.GA3396194@roeck-us.net/
  [2]: https://lore.kernel.org/qemu-devel/20221212114409.34972-4-its@irrelevant.dk/

Fixes: f9f38e3338 ("nvme: improve performance for virtual NVMe devices")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
Klaus Jensen 2022-12-13 09:58:07 +01:00 committed by Christoph Hellwig
parent 53eab8e766
commit b5f96cb719
1 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/nvme/host/pci.c
View File

@ -144,9 +144,9 @@ struct nvme_dev {
mempool_t *iod_mempool; mempool_t *iod_mempool;
/* shadow doorbell buffer support: */ /* shadow doorbell buffer support: */
u32 *dbbuf_dbs; __le32 *dbbuf_dbs;
dma_addr_t dbbuf_dbs_dma_addr; dma_addr_t dbbuf_dbs_dma_addr;
u32 *dbbuf_eis; __le32 *dbbuf_eis;
dma_addr_t dbbuf_eis_dma_addr; dma_addr_t dbbuf_eis_dma_addr;
/* host memory buffer support: */ /* host memory buffer support: */
@ -208,10 +208,10 @@ struct nvme_queue {
#define NVMEQ_SQ_CMB 1 #define NVMEQ_SQ_CMB 1
#define NVMEQ_DELETE_ERROR 2 #define NVMEQ_DELETE_ERROR 2
#define NVMEQ_POLLED 3 #define NVMEQ_POLLED 3
u32 *dbbuf_sq_db; __le32 *dbbuf_sq_db;
u32 *dbbuf_cq_db; __le32 *dbbuf_cq_db;
u32 *dbbuf_sq_ei; __le32 *dbbuf_sq_ei;
u32 *dbbuf_cq_ei; __le32 *dbbuf_cq_ei;
struct completion delete_done; struct completion delete_done;
}; };
@ -343,11 +343,11 @@ static inline int nvme_dbbuf_need_event(u16 event_idx, u16 new_idx, u16 old)
} }
/* Update dbbuf and return true if an MMIO is required */ /* Update dbbuf and return true if an MMIO is required */
static bool nvme_dbbuf_update_and_check_event(u16 value, u32 *dbbuf_db, static bool nvme_dbbuf_update_and_check_event(u16 value, __le32 *dbbuf_db,
volatile u32 *dbbuf_ei) volatile __le32 *dbbuf_ei)
{ {
if (dbbuf_db) { if (dbbuf_db) {
u16 old_value; u16 old_value, event_idx;
/* /*
* Ensure that the queue is written before updating * Ensure that the queue is written before updating
@ -355,8 +355,8 @@ static bool nvme_dbbuf_update_and_check_event(u16 value, u32 *dbbuf_db,
*/ */
wmb(); wmb();
old_value = *dbbuf_db; old_value = le32_to_cpu(*dbbuf_db);
*dbbuf_db = value; *dbbuf_db = cpu_to_le32(value);
/* /*
* Ensure that the doorbell is updated before reading the event * Ensure that the doorbell is updated before reading the event
@ -366,7 +366,8 @@ static bool nvme_dbbuf_update_and_check_event(u16 value, u32 *dbbuf_db,
*/ */
mb(); mb();
if (!nvme_dbbuf_need_event(*dbbuf_ei, value, old_value)) event_idx = le32_to_cpu(*dbbuf_ei);
if (!nvme_dbbuf_need_event(event_idx, value, old_value))
return false; return false;
} }