iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dpll: Fix potential msg memleak when genlmsg_put_reply failed

Browse Source 
We should clean the skb resource if genlmsg_put_reply failed.

Fixes: 9d71b54b65 ("dpll: netlink: Add DPLL framework base functions")
Signed-off-by: Hao Ge <gehao@kylinos.cn>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://lore.kernel.org/r/20231121013709.73323-1-gehao@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Hao Ge 2023-11-21 09:37:09 +08:00 committed by Jakub Kicinski
parent b2d66643dc
commit b6fe6f0371
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/dpll/dpll_netlink.c
View File

@ -1093,9 +1093,10 @@ int dpll_nl_pin_id_get_doit(struct sk_buff *skb, struct genl_info *info)
return -ENOMEM; return -ENOMEM;
hdr = genlmsg_put_reply(msg, info, &dpll_nl_family, 0, hdr = genlmsg_put_reply(msg, info, &dpll_nl_family, 0,
DPLL_CMD_PIN_ID_GET); DPLL_CMD_PIN_ID_GET);
if (!hdr) if (!hdr) {
nlmsg_free(msg);
return -EMSGSIZE; return -EMSGSIZE;
}
pin = dpll_pin_find_from_nlattr(info); pin = dpll_pin_find_from_nlattr(info);
if (!IS_ERR(pin)) { if (!IS_ERR(pin)) {
ret = dpll_msg_add_pin_handle(msg, pin); ret = dpll_msg_add_pin_handle(msg, pin);
@ -1123,8 +1124,10 @@ int dpll_nl_pin_get_doit(struct sk_buff *skb, struct genl_info *info)
return -ENOMEM; return -ENOMEM;
hdr = genlmsg_put_reply(msg, info, &dpll_nl_family, 0, hdr = genlmsg_put_reply(msg, info, &dpll_nl_family, 0,
DPLL_CMD_PIN_GET); DPLL_CMD_PIN_GET);
if (!hdr) if (!hdr) {
nlmsg_free(msg);
return -EMSGSIZE; return -EMSGSIZE;
}
ret = dpll_cmd_pin_get_one(msg, pin, info->extack); ret = dpll_cmd_pin_get_one(msg, pin, info->extack);
if (ret) { if (ret) {
nlmsg_free(msg); nlmsg_free(msg);
@ -1256,8 +1259,10 @@ int dpll_nl_device_id_get_doit(struct sk_buff *skb, struct genl_info *info)
return -ENOMEM; return -ENOMEM;
hdr = genlmsg_put_reply(msg, info, &dpll_nl_family, 0, hdr = genlmsg_put_reply(msg, info, &dpll_nl_family, 0,
DPLL_CMD_DEVICE_ID_GET); DPLL_CMD_DEVICE_ID_GET);
if (!hdr) if (!hdr) {
nlmsg_free(msg);
return -EMSGSIZE; return -EMSGSIZE;
}
dpll = dpll_device_find_from_nlattr(info); dpll = dpll_device_find_from_nlattr(info);
if (!IS_ERR(dpll)) { if (!IS_ERR(dpll)) {
@ -1284,8 +1289,10 @@ int dpll_nl_device_get_doit(struct sk_buff *skb, struct genl_info *info)
return -ENOMEM; return -ENOMEM;
hdr = genlmsg_put_reply(msg, info, &dpll_nl_family, 0, hdr = genlmsg_put_reply(msg, info, &dpll_nl_family, 0,
DPLL_CMD_DEVICE_GET); DPLL_CMD_DEVICE_GET);
if (!hdr) if (!hdr) {
nlmsg_free(msg);
return -EMSGSIZE; return -EMSGSIZE;
}
ret = dpll_device_get_one(dpll, msg, info->extack); ret = dpll_device_get_one(dpll, msg, info->extack);
if (ret) { if (ret) {