iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm: memory-failure: remove unneeded page state check in shake_page()

Browse Source 
Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches
are not shrunk now.  This check can be added back when a lightweight range
based shrinker is available.

Link: https://lkml.kernel.org/r/20230628014929.3441386-1-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Miaohe Lin
2023-06-28 09:49:29 +08:00
committed by Andrew Morton
parent 64891ba3e5
commit b7b618da0e
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
mm/memory-failure.c
View File

@@ -363,17 +363,14 @@ void shake_page(struct page *p)
{ {
if (PageHuge(p)) if (PageHuge(p))
return; return;
if (!PageSlab(p)) {
lru_add_drain_all();
if (PageLRU(p) || is_free_buddy_page(p))
return;
}
/* /*
* TODO: Could shrink slab caches here if a lightweight range-based * TODO: Could shrink slab caches here if a lightweight range-based
* shrinker will be available. * shrinker will be available.
*/ */
if (PageSlab(p))
return;
lru_add_drain_all();
} }
EXPORT_SYMBOL_GPL(shake_page); EXPORT_SYMBOL_GPL(shake_page);