iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi/bitbang: avoid needless loop flow manipulations

Browse Source 
This patch makes a loop look cleaner by replacing a "break" and a "continue"
in its body by a single "if".

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
This commit is contained in:
Guennadi Liakhovetski 2012-05-21 13:25:13 +02:00 committed by Grant Likely
parent 77b67063bb
commit b82b576bc7
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/spi/spi-bitbang.c
View File

@ -346,11 +346,7 @@ static void bitbang_work(struct work_struct *work)
if (t->delay_usecs) if (t->delay_usecs)
udelay(t->delay_usecs); udelay(t->delay_usecs);
if (!cs_change) if (cs_change && !list_is_last(&t->transfer_list, &m->transfers)) {
continue;
if (t->transfer_list.next == &m->transfers)
break;
/* sometimes a short mid-message deselect of the chip /* sometimes a short mid-message deselect of the chip
* may be needed to terminate a mode or command * may be needed to terminate a mode or command
*/ */
@ -358,6 +354,7 @@ static void bitbang_work(struct work_struct *work)
bitbang->chipselect(spi, BITBANG_CS_INACTIVE); bitbang->chipselect(spi, BITBANG_CS_INACTIVE);
ndelay(nsecs); ndelay(nsecs);
} }
}
m->status = status; m->status = status;
m->complete(m->context); m->complete(m->context);