iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

netxen: clean up unnecessary MSI/MSI-X capability find

Browse Source 
PCI core will initialize device MSI/MSI-X capability in
pci_msi_init_pci_dev(). So device driver should use
pci_dev->msi_cap/msix_cap to determine whether the device
support MSI/MSI-X instead of using
pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
Access to PCIe device config space again will consume more time.

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Manish Chopra <manish.chopra@qlogic.com>
Cc: Sony Chacko <sony.chacko@qlogic.com>
Cc: Rajesh Borundia <rajesh.borundia@qlogic.com>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Yijing Wang 2013-08-08 21:02:56 +08:00 committed by David S. Miller
parent 40b2956250
commit b83082e95e
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
View File

@ -459,16 +459,14 @@ static void netxen_pcie_strap_init(struct netxen_adapter *adapter)
static void netxen_set_msix_bit(struct pci_dev *pdev, int enable) static void netxen_set_msix_bit(struct pci_dev *pdev, int enable)
{ {
u32 control; u32 control;
int pos;
pos = pci_find_capability(pdev, PCI_CAP_ID_MSIX); if (pdev->msix_cap) {
if (pos) { pci_read_config_dword(pdev, pdev->msix_cap, &control);
pci_read_config_dword(pdev, pos, &control);
if (enable) if (enable)
control |= PCI_MSIX_FLAGS_ENABLE; control |= PCI_MSIX_FLAGS_ENABLE;
else else
control = 0; control = 0;
pci_write_config_dword(pdev, pos, control); pci_write_config_dword(pdev, pdev->msix_cap, control);
} }
} }