iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

block: limit block time caching to in_task() context

Browse Source 
We should not have any callers of this from non-task context, but Jakub
ran [1] into one from blk-iocost. Rather than risk running into others,
or future ones, just limit blk_time_get_ns() to when it is called from
a task. Any other usage is invalid.

[1] https://lore.kernel.org/lkml/CAHk-=wiOaBLqarS2uFhM1YdwOvCX4CZaWkeyNDY1zONpbYw2ig@mail.gmail.com/

Fixes: da4c8c3d09 ("block: cache current nsec time in struct blk_plug")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Jens Axboe
2024-03-12 15:58:41 -06:00
parent 259f7d5e2b
commit b874d4aae5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
block/blk.h
View File

@ -534,7 +534,7 @@ static inline u64 blk_time_get_ns(void)
{ {
struct blk_plug *plug = current->plug; struct blk_plug *plug = current->plug;
if (!plug) if (!plug || !in_task())
return ktime_get_ns(); return ktime_get_ns();
/* /*