iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

securityfs: Drop dentry reference count when mknod fails

Browse Source 
lookup_one_len increments dentry reference count which is not decremented
when the create operation fails. This can cause a kernel BUG at
fs/dcache.c:676 at unmount time. Also error code returned when new_inode()
fails was replaced with more appropriate -ENOMEM.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@sophos.com>
Acked-by: Serge E. Hallyn <serge@hallyn.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: James Morris <jmorris@namei.org>
This commit is contained in:
Tvrtko Ursulin 2010-07-15 13:25:06 +01:00 committed by James Morris
parent 57a62c2317
commit b8bc83ab4d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
security/inode.c
View File

@ -86,7 +86,7 @@ static int mknod(struct inode *dir, struct dentry *dentry,
int mode, dev_t dev) int mode, dev_t dev)
{ {
struct inode *inode; struct inode *inode;
int error = -EPERM; int error = -ENOMEM;
if (dentry->d_inode) if (dentry->d_inode)
return -EEXIST; return -EEXIST;
@ -166,6 +166,8 @@ static int create_by_name(const char *name, mode_t mode,
error = mkdir(parent->d_inode, *dentry, mode); error = mkdir(parent->d_inode, *dentry, mode);
else else
error = create(parent->d_inode, *dentry, mode); error = create(parent->d_inode, *dentry, mode);
if (error)
dput(*dentry);
} else } else
error = PTR_ERR(*dentry); error = PTR_ERR(*dentry);
mutex_unlock(&parent->d_inode->i_mutex); mutex_unlock(&parent->d_inode->i_mutex);