iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] mceusb: move check earlier to make smatch happy

Browse Source 
Smatch complains that "cmdbuf[cmdcount - length]" might go past the end
of the array.  It's an easy warning to silence by moving the limit
check earlier.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter 2013-02-12 08:22:08 -03:00 committed by Mauro Carvalho Chehab
parent 4db45af5ec
commit b940a2219c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/media/rc/mceusb.c
View File

@ -828,16 +828,16 @@ static int mceusb_tx_ir(struct rc_dev *dev, unsigned *txbuf, unsigned count)
(txbuf[i] -= MCE_MAX_PULSE_LENGTH)); (txbuf[i] -= MCE_MAX_PULSE_LENGTH));
} }
/* Fix packet length in last header */
length = cmdcount % MCE_CODE_LENGTH;
cmdbuf[cmdcount - length] -= MCE_CODE_LENGTH - length;
/* Check if we have room for the empty packet at the end */ /* Check if we have room for the empty packet at the end */
if (cmdcount >= MCE_CMDBUF_SIZE) { if (cmdcount >= MCE_CMDBUF_SIZE) {
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;
} }
/* Fix packet length in last header */
length = cmdcount % MCE_CODE_LENGTH;
cmdbuf[cmdcount - length] -= MCE_CODE_LENGTH - length;
/* All mce commands end with an empty packet (0x80) */ /* All mce commands end with an empty packet (0x80) */
cmdbuf[cmdcount++] = MCE_IRDATA_TRAILER; cmdbuf[cmdcount++] = MCE_IRDATA_TRAILER;