iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regulator: s2mps11: Don't check enable_shift before setting enable ramp rate

Browse Source 
Current code misses updating the register when enable_shift is 0.
e.g. S2MPS11_BUCK9_RAMP_SHIFT and S2MPS11_BUCK6_RAMP_EN_SHIFT are 0.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Axel Lin 2014-03-21 16:16:24 +08:00 committed by Mark Brown
parent f7b1a8dc1c
commit b96244fad9
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/regulator/s2mps11.c
View File

@ -202,13 +202,11 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
if (!ramp_enable) if (!ramp_enable)
goto ramp_disable; goto ramp_disable;
if (enable_shift) { ret = regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP,
ret = regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP, 1 << enable_shift, 1 << enable_shift);
1 << enable_shift, 1 << enable_shift); if (ret) {
if (ret) { dev_err(&rdev->dev, "failed to enable ramp rate\n");
dev_err(&rdev->dev, "failed to enable ramp rate\n"); return ret;
return ret;
}
} }
ramp_val = get_ramp_delay(ramp_delay); ramp_val = get_ramp_delay(ramp_delay);