iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RDMA/i40iw: Fix a race condition

Browse Source 
Use the proper primitives to dereference the RCU pointer
upper_dev->ip_ptr. Compile-tested only.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Bart Van Assche 2017-10-11 10:49:02 -07:00 committed by Doug Ledford
parent d61d6de074
commit b965b51c55
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/infiniband/hw/i40iw/i40iw_utils.c
View File

@ -168,11 +168,16 @@ int i40iw_inetaddr_event(struct notifier_block *notifier,
if (netdev != event_netdev) if (netdev != event_netdev)
return NOTIFY_DONE; return NOTIFY_DONE;
if (upper_dev) if (upper_dev) {
local_ipaddr = ntohl( struct in_device *in;
((struct in_device *)upper_dev->ip_ptr)->ifa_list->ifa_address);
else rcu_read_lock();
in = __in_dev_get_rcu(upper_dev);
local_ipaddr = ntohl(in->ifa_list->ifa_address);
rcu_read_unlock();
} else {
local_ipaddr = ntohl(ifa->ifa_address); local_ipaddr = ntohl(ifa->ifa_address);
}
switch (event) { switch (event) {
case NETDEV_DOWN: case NETDEV_DOWN:
action = I40IW_ARP_DELETE; action = I40IW_ARP_DELETE;