iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

firmware: arm_scmi: Fix kernel doc warnings about return values

Browse Source 
Kernel doc validation script still complains about the following:

|No description found for return value of 'scmi_get_protocol_device'
|No description found for return value of 'scmi_devm_notifier_register'
|No description found for return value of 'scmi_devm_notifier_unregister'

Fix adding missing Return kernel-doc statements.

Link: https://lore.kernel.org/r/20210712143504.33541-1-cristian.marussi@arm.com
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
This commit is contained in:
Cristian Marussi 2021-07-12 15:35:04 +01:00 committed by Sudeep Holla
parent 5ff6319d46
commit b98cf55ec0
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/firmware/arm_scmi/driver.c
View File

@ -1138,6 +1138,8 @@ scmi_txrx_setup(struct scmi_info *info, struct device *dev, int prot_id)
* @proto_id and @name: if device was still not existent it is created as a * @proto_id and @name: if device was still not existent it is created as a
* child of the specified SCMI instance @info and its transport properly * child of the specified SCMI instance @info and its transport properly
* initialized as usual. * initialized as usual.
*
* Return: A properly initialized scmi device, NULL otherwise.
*/ */
static inline struct scmi_device * static inline struct scmi_device *
scmi_get_protocol_device(struct device_node *np, struct scmi_info *info, scmi_get_protocol_device(struct device_node *np, struct scmi_info *info,

4
drivers/firmware/arm_scmi/notify.c
View File

@ -1457,6 +1457,8 @@ static void scmi_devm_release_notifier(struct device *dev, void *res)
* *
* Generic devres managed helper to register a notifier_block against a * Generic devres managed helper to register a notifier_block against a
* protocol event. * protocol event.
*
* Return: 0 on Success
*/ */
static int scmi_devm_notifier_register(struct scmi_device *sdev, static int scmi_devm_notifier_register(struct scmi_device *sdev,
u8 proto_id, u8 evt_id, u8 proto_id, u8 evt_id,
@ -1523,6 +1525,8 @@ static int scmi_devm_notifier_match(struct device *dev, void *res, void *data)
* Generic devres managed helper to explicitly un-register a notifier_block * Generic devres managed helper to explicitly un-register a notifier_block
* against a protocol event, which was previously registered using the above * against a protocol event, which was previously registered using the above
* @scmi_devm_notifier_register. * @scmi_devm_notifier_register.
*
* Return: 0 on Success
*/ */
static int scmi_devm_notifier_unregister(struct scmi_device *sdev, static int scmi_devm_notifier_unregister(struct scmi_device *sdev,
u8 proto_id, u8 evt_id, u8 proto_id, u8 evt_id,