iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

devlink: Compare to size_new in case of resource child validation

Browse Source 
The current implementation checks the combined size of the children with
the 'size' of the parent. The correct behavior is to check the combined
size vs the pending change and to compare vs the 'size_new'.

Fixes: d9f9b9a4d0 ("devlink: Add support for resource abstraction")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Tested-by: Yuval Mintz <yuvalm@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Arkadi Sharshevsky 2018-02-26 10:59:53 +01:00 committed by David S. Miller
parent 4c27bf3c5b
commit b9d17175ae
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/core/devlink.c
View File

@ -2332,7 +2332,7 @@ devlink_resource_validate_children(struct devlink_resource *resource)
list_for_each_entry(child_resource, &resource->resource_list, list) list_for_each_entry(child_resource, &resource->resource_list, list)
parts_size += child_resource->size_new; parts_size += child_resource->size_new;
if (parts_size > resource->size) if (parts_size > resource->size_new)
size_valid = false; size_valid = false;
out: out:
resource->size_valid = size_valid; resource->size_valid = size_valid;