iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regmap: Fix DT endianess parsing logic

Browse Source 
Commit d647c19951 ("regmap: add DT endianness binding support.")
added support to parse the device endianness from the device tree
but unfortunately the added logic doesn't have the same semantics
than the old code. This leads to a NULL dereference pointer error
when these properties are not provided by the Device Tree:

Unable to handle kernel NULL pointer dereference at virtual address 00000044
pgd = c0004000
[00000044] *pgd=00000000
Internal error: Oops: 5 [#1] PREEMPT SMP ARM
Modules linked in:
CPU: 5 PID: 1 Comm: swapper/0 Not tainted 3.17.0-rc1-next-20140818ccu #671
task: ea412800 ti: ea484000 task.ti: ea484000
PC is at regmap_update_bits+0xc/0x5c

The problem is that platforms that rely on the default value now
gets different values due two related issues in the current code:

a) It only parses the endianness from DT for the regmap registers
   and not for the regmap values but it checks unconditionally in
   both cases if the resulting endiannes is REGMAP_ENDIAN_NATIVE.

b) REGMAP_ENDIAN_NATIVE is not even a valid DT property according
   to the regmap DT binding documentation so it shouldn't be set.

Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Signed-off-by: Mark Brown <broonie@linaro.org>
This commit is contained in:
Javier Martinez Canillas 2014-08-18 15:09:02 +02:00 committed by Mark Brown
parent 275876e208
commit ba1b53feb8
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/base/regmap/regmap.c
View File

@ -499,7 +499,6 @@ static int of_regmap_get_endian(struct device *dev,
* From the DT node the endianness value maybe:
* REGMAP_ENDIAN_BIG,
* REGMAP_ENDIAN_LITTLE,
* REGMAP_ENDIAN_NATIVE,
*/
switch (type) {
case REGMAP_ENDIAN_VAL:
@ -507,8 +506,10 @@ static int of_regmap_get_endian(struct device *dev,
*endian = REGMAP_ENDIAN_BIG;
else if (of_property_read_bool(np, "little-endian"))
*endian = REGMAP_ENDIAN_LITTLE;
else
*endian = REGMAP_ENDIAN_NATIVE;
if (*endian != REGMAP_ENDIAN_DEFAULT)
return 0;
break;
case REGMAP_ENDIAN_REG:
break;
@ -516,15 +517,6 @@ static int of_regmap_get_endian(struct device *dev,
return -EINVAL;
}
/*
* If the endianness parsed from DT node is REGMAP_ENDIAN_NATIVE, that
* maybe means the DT does not care the endianness or it should use
* the regmap bus's default endianness, then we should try to check
* whether the regmap bus has specified the default endianness.
*/
if (*endian != REGMAP_ENDIAN_NATIVE)
return 0;
/*
* Finally, try to parse the endianness from regmap bus config
* if in device's DT node the endianness property is absent.