iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regulator: userspace-consumer: use DEVICE_ATTR_RO/RW macro

Browse Source 
Use DEVICE_ATTR_RO/RW macro helper instead of plain DEVICE_ATTR, which
makes the code a bit shorter and easier to read.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210602080526.11117-1-thunder.leizhen@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Zhen Lei 2021-06-02 16:05:26 +08:00 committed by Mark Brown
parent de20b747c5
commit ba499a50ce
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/regulator/userspace-consumer.c
View File

@ -29,15 +29,15 @@ struct userspace_consumer_data {
struct regulator_bulk_data *supplies; struct regulator_bulk_data *supplies;
}; };
static ssize_t reg_show_name(struct device *dev, static ssize_t name_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
struct userspace_consumer_data *data = dev_get_drvdata(dev); struct userspace_consumer_data *data = dev_get_drvdata(dev);
return sprintf(buf, "%s\n", data->name); return sprintf(buf, "%s\n", data->name);
} }
static ssize_t reg_show_state(struct device *dev, static ssize_t state_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
struct userspace_consumer_data *data = dev_get_drvdata(dev); struct userspace_consumer_data *data = dev_get_drvdata(dev);
@ -48,8 +48,8 @@ static ssize_t reg_show_state(struct device *dev,
return sprintf(buf, "disabled\n"); return sprintf(buf, "disabled\n");
} }
static ssize_t reg_set_state(struct device *dev, struct device_attribute *attr, static ssize_t state_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count) const char *buf, size_t count)
{ {
struct userspace_consumer_data *data = dev_get_drvdata(dev); struct userspace_consumer_data *data = dev_get_drvdata(dev);
bool enabled; bool enabled;
@ -87,8 +87,8 @@ static ssize_t reg_set_state(struct device *dev, struct device_attribute *attr,
return count; return count;
} }
static DEVICE_ATTR(name, 0444, reg_show_name, NULL); static DEVICE_ATTR_RO(name);
static DEVICE_ATTR(state, 0644, reg_show_state, reg_set_state); static DEVICE_ATTR_RW(state);
static struct attribute *attributes[] = { static struct attribute *attributes[] = {
&dev_attr_name.attr, &dev_attr_name.attr,