iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vfio-pci/zdev: different maxstbl for interpreted devices

Browse Source 
When doing load/store interpretation, the maximum store block length is
determined by the underlying firmware, not the host kernel API.  Reflect
that in the associated Query PCI Function Group clp capability and let
userspace decide which is appropriate to present to the guest.

Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Link: https://lore.kernel.org/r/20220606203325.110625-20-mjrosato@linux.ibm.com
Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
This commit is contained in:
Matthew Rosato 2022-06-06 16:33:23 -04:00 committed by Christian Borntraeger
parent faf3bfcb89
commit ba6090ff8a
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/vfio/pci/vfio_pci_zdev.c
View File

@ -45,14 +45,16 @@ static int zpci_group_cap(struct zpci_dev *zdev, struct vfio_info_cap *caps)
{ {
struct vfio_device_info_cap_zpci_group cap = { struct vfio_device_info_cap_zpci_group cap = {
.header.id = VFIO_DEVICE_INFO_CAP_ZPCI_GROUP, .header.id = VFIO_DEVICE_INFO_CAP_ZPCI_GROUP,
.header.version = 1, .header.version = 2,
.dasm = zdev->dma_mask, .dasm = zdev->dma_mask,
.msi_addr = zdev->msi_addr, .msi_addr = zdev->msi_addr,
.flags = VFIO_DEVICE_INFO_ZPCI_FLAG_REFRESH, .flags = VFIO_DEVICE_INFO_ZPCI_FLAG_REFRESH,
.mui = zdev->fmb_update, .mui = zdev->fmb_update,
.noi = zdev->max_msi, .noi = zdev->max_msi,
.maxstbl = ZPCI_MAX_WRITE_SIZE, .maxstbl = ZPCI_MAX_WRITE_SIZE,
.version = zdev->version .version = zdev->version,
.reserved = 0,
.imaxstbl = zdev->maxstbl
}; };
return vfio_info_add_capability(caps, &cap.header, sizeof(cap)); return vfio_info_add_capability(caps, &cap.header, sizeof(cap));

4
include/uapi/linux/vfio_zdev.h
View File

@ -50,6 +50,10 @@ struct vfio_device_info_cap_zpci_group {
__u16 noi; /* Maximum number of MSIs */ __u16 noi; /* Maximum number of MSIs */
__u16 maxstbl; /* Maximum Store Block Length */ __u16 maxstbl; /* Maximum Store Block Length */
__u8 version; /* Supported PCI Version */ __u8 version; /* Supported PCI Version */
/* End of version 1 */
__u8 reserved;
__u16 imaxstbl; /* Maximum Interpreted Store Block Length */
/* End of version 2 */
}; };
/** /**