iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cpufreq: Prefer to print cpuid in MIN/MAX QoS register error message

Browse Source 
When a cpufreq_policy is allocated, the cpus, related_cpus and real_cpus
of policy are still unset. Therefore, it is preferable to print the
passed 'cpu' parameter instead of a empty 'cpus' cpumask in error
message when registering MIN/MAX QoS notifier fails.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
This commit is contained in:
Liao Chang 2023-08-15 09:40:02 +08:00 committed by Viresh Kumar
parent d3dec5bb61
commit ba6ea77d0e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/cpufreq/cpufreq.c
View File

@ -1234,16 +1234,16 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu)
ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MIN, ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MIN,
&policy->nb_min); &policy->nb_min);
if (ret) { if (ret) {
dev_err(dev, "Failed to register MIN QoS notifier: %d (%*pbl)\n", dev_err(dev, "Failed to register MIN QoS notifier: %d (CPU%u)\n",
ret, cpumask_pr_args(policy->cpus)); ret, cpu);
goto err_kobj_remove; goto err_kobj_remove;
} }
ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MAX, ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MAX,
&policy->nb_max); &policy->nb_max);
if (ret) { if (ret) {
dev_err(dev, "Failed to register MAX QoS notifier: %d (%*pbl)\n", dev_err(dev, "Failed to register MAX QoS notifier: %d (CPU%u)\n",
ret, cpumask_pr_args(policy->cpus)); ret, cpu);
goto err_min_qos_notifier; goto err_min_qos_notifier;
} }