iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: v4l2-subdev: fix some NULL vs IS_ERR() checks

Browse Source 
The v4l2_subdev_alloc_state() function returns error pointers, it
doesn't return NULL.

Fixes: 0d346d2a6f54 ("media: v4l2-subdev: add subdev-wide state struct")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Dan Carpenter 2021-06-22 16:31:53 +02:00 committed by Mauro Carvalho Chehab
parent 6f5885a775
commit ba7a93e507
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/platform/rcar-vin/rcar-v4l2.c
View File

@ -253,8 +253,8 @@ static int rvin_try_format(struct rvin_dev *vin, u32 which,
int ret; int ret;
sd_state = v4l2_subdev_alloc_state(sd); sd_state = v4l2_subdev_alloc_state(sd);
if (sd_state == NULL) if (IS_ERR(sd_state))
return -ENOMEM; return PTR_ERR(sd_state);
if (!rvin_format_from_pixel(vin, pix->pixelformat)) if (!rvin_format_from_pixel(vin, pix->pixelformat))
pix->pixelformat = RVIN_DEFAULT_FORMAT; pix->pixelformat = RVIN_DEFAULT_FORMAT;

4
drivers/media/platform/vsp1/vsp1_entity.c
View File

@ -676,9 +676,9 @@ int vsp1_entity_init(struct vsp1_device *vsp1, struct vsp1_entity *entity,
* rectangles. * rectangles.
*/ */
entity->config = v4l2_subdev_alloc_state(&entity->subdev); entity->config = v4l2_subdev_alloc_state(&entity->subdev);
if (entity->config == NULL) { if (IS_ERR(entity->config)) {
media_entity_cleanup(&entity->subdev.entity); media_entity_cleanup(&entity->subdev.entity);
return -ENOMEM; return PTR_ERR(entity->config);
} }
return 0; return 0;

4
drivers/staging/media/tegra-video/vi.c
View File

@ -508,8 +508,8 @@ static int __tegra_channel_try_format(struct tegra_vi_channel *chan,
return -ENODEV; return -ENODEV;
sd_state = v4l2_subdev_alloc_state(subdev); sd_state = v4l2_subdev_alloc_state(subdev);
if (!sd_state) if (IS_ERR(sd_state))
return -ENOMEM; return PTR_ERR(sd_state);
/* /*
* Retrieve the format information and if requested format isn't * Retrieve the format information and if requested format isn't
* supported, keep the current format. * supported, keep the current format.