iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

NFSv4.1: Fix the client behaviour on NFS4ERR_SEQ_FALSE_RETRY

Browse Source 
[ Upstream commit f9312a5410 ]

If the server returns NFS4ERR_SEQ_FALSE_RETRY or NFS4ERR_RETRY_UNCACHED_REP,
then it thinks we're trying to replay an existing request. If so, then
let's just bump the sequence ID and retry the operation.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Trond Myklebust
2018-06-09 19:10:31 -04:00
committed by Greg Kroah-Hartman
parent 42b1df406a
commit baad2bf447
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
fs/nfs/nfs4proc.c
View File

@ -745,6 +745,13 @@ static int nfs41_sequence_process(struct rpc_task *task,
slot->slot_nr, slot->slot_nr,
slot->seq_nr); slot->seq_nr);
goto out_retry; goto out_retry;
case -NFS4ERR_RETRY_UNCACHED_REP:
case -NFS4ERR_SEQ_FALSE_RETRY:
/*
* The server thinks we tried to replay a request.
* Retry the call after bumping the sequence ID.
*/
goto retry_new_seq;
case -NFS4ERR_BADSLOT: case -NFS4ERR_BADSLOT:
/* /*
* The slot id we used was probably retired. Try again * The slot id we used was probably retired. Try again
@ -769,10 +776,6 @@ static int nfs41_sequence_process(struct rpc_task *task,
goto retry_nowait; goto retry_nowait;
} }
goto session_recover; goto session_recover;
case -NFS4ERR_SEQ_FALSE_RETRY:
if (interrupted)
goto retry_new_seq;
goto session_recover;
default: default:
/* Just update the slot sequence no. */ /* Just update the slot sequence no. */
slot->seq_done = 1; slot->seq_done = 1;