iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] switch ide_disk_ops ->ioctl() to sane prototype

Browse Source 
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2008-10-16 10:23:20 -04:00
parent 83ff6fe858
commit badf8082c3
6 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/ide/ide-disk.h
View File

@ -13,7 +13,7 @@ ide_decl_devset(wcache);
ide_decl_devset(acoustic); ide_decl_devset(acoustic);
/* ide-disk_ioctl.c */ /* ide-disk_ioctl.c */
int ide_disk_ioctl(ide_drive_t *, struct inode *, struct file *, unsigned int, int ide_disk_ioctl(ide_drive_t *, struct block_device *, fmode_t, unsigned int,
unsigned long); unsigned long);
#ifdef CONFIG_IDE_PROC_FS #ifdef CONFIG_IDE_PROC_FS

3
drivers/ide/ide-disk_ioctl.c
View File

@ -13,10 +13,9 @@ static const struct ide_ioctl_devset ide_disk_ioctl_settings[] = {
{ 0 } { 0 }
}; };
int ide_disk_ioctl(ide_drive_t *drive, struct inode *inode, struct file *file, int ide_disk_ioctl(ide_drive_t *drive, struct block_device *bdev, fmode_t mode,
unsigned int cmd, unsigned long arg) unsigned int cmd, unsigned long arg)
{ {
struct block_device *bdev = inode->i_bdev;
int err; int err;
err = ide_setting_ioctl(drive, bdev, cmd, arg, ide_disk_ioctl_settings); err = ide_setting_ioctl(drive, bdev, cmd, arg, ide_disk_ioctl_settings);

4
drivers/ide/ide-floppy.h
View File

@ -23,8 +23,8 @@ void ide_floppy_create_mode_sense_cmd(struct ide_atapi_pc *, u8);
void ide_floppy_create_read_capacity_cmd(struct ide_atapi_pc *); void ide_floppy_create_read_capacity_cmd(struct ide_atapi_pc *);
/* ide-floppy_ioctl.c */ /* ide-floppy_ioctl.c */
int ide_floppy_ioctl(ide_drive_t *, struct inode *, struct file *, unsigned int, int ide_floppy_ioctl(ide_drive_t *, struct block_device *, fmode_t,
unsigned long); unsigned int, unsigned long);
#ifdef CONFIG_IDE_PROC_FS #ifdef CONFIG_IDE_PROC_FS
/* ide-floppy_proc.c */ /* ide-floppy_proc.c */

13
drivers/ide/ide-floppy_ioctl.c
View File

@ -241,7 +241,7 @@ static int ide_floppy_lockdoor(ide_drive_t *drive, struct ide_atapi_pc *pc,
return 0; return 0;
} }
static int ide_floppy_format_ioctl(ide_drive_t *drive, struct file *file, static int ide_floppy_format_ioctl(ide_drive_t *drive, fmode_t mode,
unsigned int cmd, void __user *argp) unsigned int cmd, void __user *argp)
{ {
switch (cmd) { switch (cmd) {
@ -250,7 +250,7 @@ static int ide_floppy_format_ioctl(ide_drive_t *drive, struct file *file,
case IDEFLOPPY_IOCTL_FORMAT_GET_CAPACITY: case IDEFLOPPY_IOCTL_FORMAT_GET_CAPACITY:
return ide_floppy_get_format_capacities(drive, argp); return ide_floppy_get_format_capacities(drive, argp);
case IDEFLOPPY_IOCTL_FORMAT_START: case IDEFLOPPY_IOCTL_FORMAT_START:
if (!(file->f_mode & FMODE_WRITE)) if (!(mode & FMODE_WRITE))
return -EPERM; return -EPERM;
return ide_floppy_format_unit(drive, (int __user *)argp); return ide_floppy_format_unit(drive, (int __user *)argp);
case IDEFLOPPY_IOCTL_FORMAT_GET_PROGRESS: case IDEFLOPPY_IOCTL_FORMAT_GET_PROGRESS:
@ -260,10 +260,9 @@ static int ide_floppy_format_ioctl(ide_drive_t *drive, struct file *file,
} }
} }
int ide_floppy_ioctl(ide_drive_t *drive, struct inode *inode, int ide_floppy_ioctl(ide_drive_t *drive, struct block_device *bdev,
struct file *file, unsigned int cmd, unsigned long arg) fmode_t mode, unsigned int cmd, unsigned long arg)
{ {
struct block_device *bdev = inode->i_bdev;
struct ide_atapi_pc pc; struct ide_atapi_pc pc;
void __user *argp = (void __user *)arg; void __user *argp = (void __user *)arg;
int err; int err;
@ -271,7 +270,7 @@ int ide_floppy_ioctl(ide_drive_t *drive, struct inode *inode,
if (cmd == CDROMEJECT || cmd == CDROM_LOCKDOOR) if (cmd == CDROMEJECT || cmd == CDROM_LOCKDOOR)
return ide_floppy_lockdoor(drive, &pc, arg, cmd); return ide_floppy_lockdoor(drive, &pc, arg, cmd);
err = ide_floppy_format_ioctl(drive, file, cmd, argp); err = ide_floppy_format_ioctl(drive, mode, cmd, argp);
if (err != -ENOTTY) if (err != -ENOTTY)
return err; return err;
@ -281,7 +280,7 @@ int ide_floppy_ioctl(ide_drive_t *drive, struct inode *inode,
*/ */
if (cmd != CDROM_SEND_PACKET && cmd != SCSI_IOCTL_SEND_COMMAND) if (cmd != CDROM_SEND_PACKET && cmd != SCSI_IOCTL_SEND_COMMAND)
err = scsi_cmd_ioctl(bdev->bd_disk->queue, bdev->bd_disk, err = scsi_cmd_ioctl(bdev->bd_disk->queue, bdev->bd_disk,
file ? file->f_mode : 0, cmd, argp); mode, cmd, argp);
if (err == -ENOTTY) if (err == -ENOTTY)
err = generic_ide_ioctl(drive, bdev, cmd, arg); err = generic_ide_ioctl(drive, bdev, cmd, arg);

2
drivers/ide/ide-gd.c
View File

@ -293,7 +293,7 @@ static int ide_gd_ioctl(struct inode *inode, struct file *file,
struct ide_disk_obj *idkp = ide_drv_g(bdev->bd_disk, ide_disk_obj); struct ide_disk_obj *idkp = ide_drv_g(bdev->bd_disk, ide_disk_obj);
ide_drive_t *drive = idkp->drive; ide_drive_t *drive = idkp->drive;
return drive->disk_ops->ioctl(drive, inode, file, cmd, arg); return drive->disk_ops->ioctl(drive, bdev, file ? file->f_mode : 0, cmd, arg);
} }
static struct block_device_operations ide_gd_ops = { static struct block_device_operations ide_gd_ops = {

4
include/linux/ide.h
View File

@ -474,8 +474,8 @@ struct ide_disk_ops {
ide_startstop_t (*do_request)(struct ide_drive_s *, struct request *, ide_startstop_t (*do_request)(struct ide_drive_s *, struct request *,
sector_t); sector_t);
int (*end_request)(struct ide_drive_s *, int, int); int (*end_request)(struct ide_drive_s *, int, int);
int (*ioctl)(struct ide_drive_s *, struct inode *, int (*ioctl)(struct ide_drive_s *, struct block_device *,
struct file *, unsigned int, unsigned long); fmode_t, unsigned int, unsigned long);
}; };
/* ATAPI device flags */ /* ATAPI device flags */