iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: venus: core: Fix runtime PM imbalance in venus_probe

Browse Source 
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced. For other error
paths after this call, things are the same.

Fix this by adding pm_runtime_put_noidle() after 'err_runtime_disable'
label. But in this case, the error path after pm_runtime_put_sync()
will decrease PM usage counter twice. Thus add an extra
pm_runtime_get_noresume() in this path to balance PM counter.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Dinghao Liu 2020-06-28 07:55:23 +02:00 committed by Mauro Carvalho Chehab
parent 5cef078536
commit bbe516e976
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/media/platform/qcom/venus/core.c
View File

@ -287,8 +287,10 @@ static int venus_probe(struct platform_device *pdev)
goto err_core_deinit; goto err_core_deinit;
ret = pm_runtime_put_sync(dev); ret = pm_runtime_put_sync(dev);
if (ret) if (ret) {
pm_runtime_get_noresume(dev);
goto err_dev_unregister; goto err_dev_unregister;
}
return 0; return 0;
@ -299,6 +301,7 @@ err_core_deinit:
err_venus_shutdown: err_venus_shutdown:
venus_shutdown(core); venus_shutdown(core);
err_runtime_disable: err_runtime_disable:
pm_runtime_put_noidle(dev);
pm_runtime_set_suspended(dev); pm_runtime_set_suspended(dev);
pm_runtime_disable(dev); pm_runtime_disable(dev);
hfi_destroy(core); hfi_destroy(core);