iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: scsi_dh_alua: Remove check for ASC 24h in alua_rtpg()

Browse Source 
Some arrays return ILLEGAL_REQUEST with ASC 00h if they don't support the
RTPG extended header so remove the check for INVALID FIELD IN CDB.

Link: https://lore.kernel.org/r/20210331201154.20348-1-emilne@redhat.com
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Ewan D. Milne 2021-03-31 16:11:54 -04:00 committed by Martin K. Petersen
parent 22ec513e70
commit bc3f2b42b7
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/scsi/device_handler/scsi_dh_alua.c
View File

@ -579,10 +579,11 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
* even though it shouldn't according to T10. * even though it shouldn't according to T10.
* The retry without rtpg_ext_hdr_req set * The retry without rtpg_ext_hdr_req set
* handles this. * handles this.
* Note: some arrays return a sense key of ILLEGAL_REQUEST
* with ASC 00h if they don't support the extended header.
*/ */
if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) && if (!(pg->flags & ALUA_RTPG_EXT_HDR_UNSUPP) &&
sense_hdr.sense_key == ILLEGAL_REQUEST && sense_hdr.sense_key == ILLEGAL_REQUEST) {
sense_hdr.asc == 0x24 && sense_hdr.ascq == 0) {
pg->flags |= ALUA_RTPG_EXT_HDR_UNSUPP; pg->flags |= ALUA_RTPG_EXT_HDR_UNSUPP;
goto retry; goto retry;
} }