iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i2c: mpc: make interrupt mandatory and remove polling code

Browse Source 
All the in-tree dts files that use one of the compatible strings from
i2c-mpc.c provide an interrupt property. By making this mandatory we
can simplify the code.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
Chris Packham 2021-03-29 14:52:04 +13:00 committed by Wolfram Sang
parent 65171b2df1
commit bc72675228
1 changed files with 19 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
drivers/i2c/busses/i2c-mpc.c
View File

@ -123,37 +123,21 @@ static void mpc_i2c_fixup(struct mpc_i2c *i2c)
static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing) static int i2c_wait(struct mpc_i2c *i2c, unsigned timeout, int writing)
{ {
unsigned long orig_jiffies = jiffies;
u32 cmd_err; u32 cmd_err;
int result = 0; int result;
if (!i2c->irq) { result = wait_event_timeout(i2c->queue,
while (!(readb(i2c->base + MPC_I2C_SR) & CSR_MIF)) {
schedule();
if (time_after(jiffies, orig_jiffies + timeout)) {
dev_dbg(i2c->dev, "timeout\n");
writeccr(i2c, 0);
result = -ETIMEDOUT;
break;
}
}
cmd_err = readb(i2c->base + MPC_I2C_SR);
writeb(0, i2c->base + MPC_I2C_SR);
} else {
/* Interrupt mode */
result = wait_event_timeout(i2c->queue,
(i2c->interrupt & CSR_MIF), timeout); (i2c->interrupt & CSR_MIF), timeout);
if (unlikely(!(i2c->interrupt & CSR_MIF))) { if (unlikely(!(i2c->interrupt & CSR_MIF))) {
dev_dbg(i2c->dev, "wait timeout\n"); dev_dbg(i2c->dev, "wait timeout\n");
writeccr(i2c, 0); writeccr(i2c, 0);
result = -ETIMEDOUT; result = -ETIMEDOUT;
}
cmd_err = i2c->interrupt;
i2c->interrupt = 0;
} }
cmd_err = i2c->interrupt;
i2c->interrupt = 0;
if (result < 0) if (result < 0)
return result; return result;
@ -694,13 +678,16 @@ static int fsl_i2c_probe(struct platform_device *op)
} }
i2c->irq = irq_of_parse_and_map(op->dev.of_node, 0); i2c->irq = irq_of_parse_and_map(op->dev.of_node, 0);
if (i2c->irq) { /* no i2c->irq implies polling */ if (i2c->irq < 0) {
result = request_irq(i2c->irq, mpc_i2c_isr, result = i2c->irq;
IRQF_SHARED, "i2c-mpc", i2c); goto fail_map;
if (result < 0) { }
dev_err(i2c->dev, "failed to attach interrupt\n");
goto fail_request; result = request_irq(i2c->irq, mpc_i2c_isr,
} IRQF_SHARED, "i2c-mpc", i2c);
if (result < 0) {
dev_err(i2c->dev, "failed to attach interrupt\n");
goto fail_request;
} }
/* /*