iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cifs: cifs_inval_name_dfs_link_error: correct the check for fullpath

Browse Source 
[ Upstream commit 36bb22a08a69d9984a8399c07310d18b115eae20 ]

Replace the always-true check tcon->origin_fullpath with
check of server->leaf_fullpath

See https://bugzilla.kernel.org/show_bug.cgi?id=219083

The check of the new @tcon will always be true during mounting,
since @tcon->origin_fullpath will only be set after the tree is
connected to the latest common resource, as well as checking if
the prefix paths from it are fully accessible.

Fixes: 3ae872de4107 ("smb: client: fix shared DFS root mounts with different prefixes")
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Gleb Korobeynikov <gkorobeynikov@astralinux.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Gleb Korobeynikov 2024-08-08 18:47:48 +03:00 committed by Greg Kroah-Hartman
parent f1c0338656
commit bc7467911d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/smb/client/misc.c
View File

@ -1288,6 +1288,7 @@ int cifs_inval_name_dfs_link_error(const unsigned int xid,
const char *full_path, const char *full_path,
bool *islink) bool *islink)
{ {
struct TCP_Server_Info *server = tcon->ses->server;
struct cifs_ses *ses = tcon->ses; struct cifs_ses *ses = tcon->ses;
size_t len; size_t len;
char *path; char *path;
@ -1304,12 +1305,12 @@ int cifs_inval_name_dfs_link_error(const unsigned int xid,
!is_tcon_dfs(tcon)) !is_tcon_dfs(tcon))
return 0; return 0;
spin_lock(&tcon->tc_lock); spin_lock(&server->srv_lock);
if (!tcon->origin_fullpath) { if (!server->leaf_fullpath) {
spin_unlock(&tcon->tc_lock); spin_unlock(&server->srv_lock);
return 0; return 0;
} }
spin_unlock(&tcon->tc_lock); spin_unlock(&server->srv_lock);
/* /*
* Slow path - tcon is DFS and @full_path has prefix path, so attempt * Slow path - tcon is DFS and @full_path has prefix path, so attempt