iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dma-buf/sync_file: use strscpy to replace strlcpy

Browse Source 
The strlcpy should not be used because it doesn't limit the source
length. Preferred is strscpy.

Signed-off-by: XueBing Chen <chenxuebing@jari.cn>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/6aad3bff.d1a.181b982d1b1.Coremail.chenxuebing@jari.cn
This commit is contained in:
XueBing Chen 2022-07-01 19:26:07 +08:00 committed by Daniel Vetter
parent 7350b2a3fb
commit bcfa6be2ee
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/dma-buf/sync_file.c
View File

@ -132,7 +132,7 @@ EXPORT_SYMBOL(sync_file_get_fence);
char *sync_file_get_name(struct sync_file *sync_file, char *buf, int len) char *sync_file_get_name(struct sync_file *sync_file, char *buf, int len)
{ {
if (sync_file->user_name[0]) { if (sync_file->user_name[0]) {
strlcpy(buf, sync_file->user_name, len); strscpy(buf, sync_file->user_name, len);
} else { } else {
struct dma_fence *fence = sync_file->fence; struct dma_fence *fence = sync_file->fence;
@ -172,7 +172,7 @@ static struct sync_file *sync_file_merge(const char *name, struct sync_file *a,
return NULL; return NULL;
} }
sync_file->fence = fence; sync_file->fence = fence;
strlcpy(sync_file->user_name, name, sizeof(sync_file->user_name)); strscpy(sync_file->user_name, name, sizeof(sync_file->user_name));
return sync_file; return sync_file;
} }
@ -262,9 +262,9 @@ err_put_fd:
static int sync_fill_fence_info(struct dma_fence *fence, static int sync_fill_fence_info(struct dma_fence *fence,
struct sync_fence_info *info) struct sync_fence_info *info)
{ {
strlcpy(info->obj_name, fence->ops->get_timeline_name(fence), strscpy(info->obj_name, fence->ops->get_timeline_name(fence),
sizeof(info->obj_name)); sizeof(info->obj_name));
strlcpy(info->driver_name, fence->ops->get_driver_name(fence), strscpy(info->driver_name, fence->ops->get_driver_name(fence),
sizeof(info->driver_name)); sizeof(info->driver_name));
info->status = dma_fence_get_status(fence); info->status = dma_fence_get_status(fence);