drm/amdkfd: Use memdup_user() rather than duplicating its implementation
To prevent its redundant implementation and streamline code, use memdup_user. This fixes warnings reported by Coccinelle: ./drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c:2811:13-20: WARNING opportunity for memdup_user Signed-off-by: Atul Raut <rauji.raut@gmail.com> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
parent
8b3a7a707c
commit
bd6040b0ea
@ -2817,19 +2817,11 @@ static void copy_context_work_handler (struct work_struct *work)
|
||||
static uint32_t *get_queue_ids(uint32_t num_queues, uint32_t *usr_queue_id_array)
|
||||
{
|
||||
size_t array_size = num_queues * sizeof(uint32_t);
|
||||
uint32_t *queue_ids = NULL;
|
||||
|
||||
if (!usr_queue_id_array)
|
||||
return NULL;
|
||||
|
||||
queue_ids = kzalloc(array_size, GFP_KERNEL);
|
||||
if (!queue_ids)
|
||||
return ERR_PTR(-ENOMEM);
|
||||
|
||||
if (copy_from_user(queue_ids, usr_queue_id_array, array_size))
|
||||
return ERR_PTR(-EFAULT);
|
||||
|
||||
return queue_ids;
|
||||
return memdup_user(usr_queue_id_array, array_size);
|
||||
}
|
||||
|
||||
int resume_queues(struct kfd_process *p,
|
||||
|
Loading…
x
Reference in New Issue
Block a user