iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: r8188eu: fix a memory leak in rtw_wx_read32()

Browse Source 
Free "ptmp" before returning -EINVAL.

Fixes: 2b42bd58b3 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211109114935.GC16587@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter
2021-11-09 14:49:36 +03:00
committed by Greg Kroah-Hartman
parent 4a293eaf92
commit be4ea8f383
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/staging/r8188eu/os_dep/ioctl_linux.c
View File

@ -1980,6 +1980,7 @@ static int rtw_wx_read32(struct net_device *dev,
u32 data32; u32 data32;
u32 bytes; u32 bytes;
u8 *ptmp; u8 *ptmp;
int ret;
padapter = (struct adapter *)rtw_netdev_priv(dev); padapter = (struct adapter *)rtw_netdev_priv(dev);
p = &wrqu->data; p = &wrqu->data;
@ -2007,12 +2008,17 @@ static int rtw_wx_read32(struct net_device *dev,
break; break;
default: default:
DBG_88E(KERN_INFO "%s: usage> read [bytes],[address(hex)]\n", __func__); DBG_88E(KERN_INFO "%s: usage> read [bytes],[address(hex)]\n", __func__);
return -EINVAL; ret = -EINVAL;
goto err_free_ptmp;
} }
DBG_88E(KERN_INFO "%s: addr = 0x%08X data =%s\n", __func__, addr, extra); DBG_88E(KERN_INFO "%s: addr = 0x%08X data =%s\n", __func__, addr, extra);
kfree(ptmp); kfree(ptmp);
return 0; return 0;
err_free_ptmp:
kfree(ptmp);
return ret;
} }
static int rtw_wx_write32(struct net_device *dev, static int rtw_wx_write32(struct net_device *dev,