iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf diff: Change default setting to "delta-abs"

Browse Source 
The "delta-abs" compute method will show most changed entries on top.
So users can easily see how much effect between the data.  Note that it
also changes the default of -o option to 1 in order to apply the compute
method.  To see original-style (sorted by baseline) use -o 0 option.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20170210161856.18422-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Namhyung Kim 2017-02-11 01:18:56 +09:00 committed by Arnaldo Carvalho de Melo
parent 4b35994abe
commit be57b3fd21
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/perf/Documentation/perf-diff.txt
View File

@ -87,7 +87,7 @@ OPTIONS
-c:: -c::
--compute:: --compute::
Differential computation selection - delta, ratio, wdiff, delta-abs Differential computation selection - delta, ratio, wdiff, delta-abs
(default is delta). Default can be changed using diff.compute (default is delta-abs). Default can be changed using diff.compute
config option. See COMPARISON METHODS section for more info. config option. See COMPARISON METHODS section for more info.
-p:: -p::
@ -101,7 +101,7 @@ OPTIONS
-o:: -o::
--order:: --order::
Specify compute sorting column number. 0 means sorting by baseline Specify compute sorting column number. 0 means sorting by baseline
overhead (default) and 1 means sorting by computed value of column 1 overhead and 1 (default) means sorting by computed value of column 1
(data from the first file other base baseline). Values more than 1 (data from the first file other base baseline). Values more than 1
can be used only if enough data files are provided. can be used only if enough data files are provided.
The default value can be set using the diff.order config option. The default value can be set using the diff.order config option.

6
tools/perf/builtin-diff.c
View File

@ -66,7 +66,7 @@ static bool force;
static bool show_period; static bool show_period;
static bool show_formula; static bool show_formula;
static bool show_baseline_only; static bool show_baseline_only;
static unsigned int sort_compute; static unsigned int sort_compute = 1;
static s64 compute_wdiff_w1; static s64 compute_wdiff_w1;
static s64 compute_wdiff_w2; static s64 compute_wdiff_w2;
@ -86,7 +86,7 @@ const char *compute_names[COMPUTE_MAX] = {
[COMPUTE_WEIGHTED_DIFF] = "wdiff", [COMPUTE_WEIGHTED_DIFF] = "wdiff",
}; };
static int compute = COMPUTE_DELTA; static int compute = COMPUTE_DELTA_ABS;
static int compute_2_hpp[COMPUTE_MAX] = { static int compute_2_hpp[COMPUTE_MAX] = {
[COMPUTE_DELTA] = PERF_HPP_DIFF__DELTA, [COMPUTE_DELTA] = PERF_HPP_DIFF__DELTA,
@ -810,7 +810,7 @@ static const struct option options[] = {
OPT_BOOLEAN('b', "baseline-only", &show_baseline_only, OPT_BOOLEAN('b', "baseline-only", &show_baseline_only,
"Show only items with match in baseline"), "Show only items with match in baseline"),
OPT_CALLBACK('c', "compute", &compute, OPT_CALLBACK('c', "compute", &compute,
"delta,delta-abs,ratio,wdiff:w1,w2 (default delta)", "delta,delta-abs,ratio,wdiff:w1,w2 (default delta-abs)",
"Entries differential computation selection", "Entries differential computation selection",
setup_compute), setup_compute),
OPT_BOOLEAN('p', "period", &show_period, OPT_BOOLEAN('p', "period", &show_period,