iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/powernv: Fix endian bug in LPC bus debugfs accessors

Browse Source 
When reading from the LPC, the OPAL FW calls return the value via pointer
to a uint32_t which is always returned big endian. Our internal inb/outb
implementation byteswaps that fine but our debugfs code is still broken.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: <stable@vger.kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
This commit is contained in:
Benjamin Herrenschmidt 2014-10-03 17:12:25 +10:00 committed by Michael Ellerman
parent 75d43b2d0a
commit bf7588a085
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
arch/powerpc/platforms/powernv/opal-lpc.c
View File

@ -191,6 +191,7 @@ static ssize_t lpc_debug_read(struct file *filp, char __user *ubuf,
{ {
struct lpc_debugfs_entry *lpc = filp->private_data; struct lpc_debugfs_entry *lpc = filp->private_data;
u32 data, pos, len, todo; u32 data, pos, len, todo;
__be32 bedata;
int rc; int rc;
if (!access_ok(VERIFY_WRITE, ubuf, count)) if (!access_ok(VERIFY_WRITE, ubuf, count))
@ -213,9 +214,10 @@ static ssize_t lpc_debug_read(struct file *filp, char __user *ubuf,
len = 2; len = 2;
} }
rc = opal_lpc_read(opal_lpc_chip_id, lpc->lpc_type, pos, rc = opal_lpc_read(opal_lpc_chip_id, lpc->lpc_type, pos,
&data, len); &bedata, len);
if (rc) if (rc)
return -ENXIO; return -ENXIO;
data = be32_to_cpu(bedata);
switch(len) { switch(len) {
case 4: case 4:
rc = __put_user((u32)data, (u32 __user *)ubuf); rc = __put_user((u32)data, (u32 __user *)ubuf);