iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

signals: do_group_exit(): use signal_group_exit() more consistently

Browse Source 
do_group_exit() checks SIGNAL_GROUP_EXIT to avoid taking sighand->siglock.
Since ed5d2cac11 exec() doesn't set this
flag, we should use signal_group_exit().

This is not needed for correctness, but can speedup the multithreaded exec
and makes the code more consistent.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2008-04-30 00:52:36 -07:00 committed by Linus Torvalds
parent 573cf9ad72
commit bfc4b0890a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/exit.c
View File

@ -1115,12 +1115,13 @@ asmlinkage long sys_exit(int error_code)
NORET_TYPE void NORET_TYPE void
do_group_exit(int exit_code) do_group_exit(int exit_code)
{ {
struct signal_struct *sig = current->signal;
BUG_ON(exit_code & 0x80); /* core dumps don't get here */ BUG_ON(exit_code & 0x80); /* core dumps don't get here */
if (current->signal->flags & SIGNAL_GROUP_EXIT) if (signal_group_exit(sig))
exit_code = current->signal->group_exit_code; exit_code = sig->group_exit_code;
else if (!thread_group_empty(current)) { else if (!thread_group_empty(current)) {
struct signal_struct *const sig = current->signal;
struct sighand_struct *const sighand = current->sighand; struct sighand_struct *const sighand = current->sighand;
spin_lock_irq(&sighand->siglock); spin_lock_irq(&sighand->siglock);
if (signal_group_exit(sig)) if (signal_group_exit(sig))