iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RDMA/rxe: Change mcg_lock to a _bh lock

Browse Source 
rxe_mcast.c currently uses _irqsave spinlocks for rxe->mcg_lock while
rxe_recv.c uses _bh spinlocks for the same lock.

As there is no case where the mcg_lock can be taken from an IRQ, change
these all to bh locks so we don't have confusing mismatched lock types on
the same spinlock.

Fixes: 6090a0c4c7 ("RDMA/rxe: Cleanup rxe_mcast.c")
Link: https://lore.kernel.org/r/20220504202817.98247-1-rpearsonhpe@gmail.com
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Bob Pearson
2022-05-04 15:28:17 -05:00
committed by Jason Gunthorpe
parent a926a903b7
commit bfdc0edd11
1 changed files with 15 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
drivers/infiniband/sw/rxe/rxe_mcast.c
View File

@ -143,11 +143,10 @@ static struct rxe_mcg *__rxe_lookup_mcg(struct rxe_dev *rxe,
struct rxe_mcg *rxe_lookup_mcg(struct rxe_dev *rxe, union ib_gid *mgid) struct rxe_mcg *rxe_lookup_mcg(struct rxe_dev *rxe, union ib_gid *mgid)
{ {
struct rxe_mcg *mcg; struct rxe_mcg *mcg;
unsigned long flags;
spin_lock_irqsave(&rxe->mcg_lock, flags); spin_lock_bh(&rxe->mcg_lock);
mcg = __rxe_lookup_mcg(rxe, mgid); mcg = __rxe_lookup_mcg(rxe, mgid);
spin_unlock_irqrestore(&rxe->mcg_lock, flags); spin_unlock_bh(&rxe->mcg_lock);
return mcg; return mcg;
} }
@ -189,7 +188,6 @@ static void __rxe_init_mcg(struct rxe_dev *rxe, union ib_gid *mgid,
static struct rxe_mcg *rxe_get_mcg(struct rxe_dev *rxe, union ib_gid *mgid) static struct rxe_mcg *rxe_get_mcg(struct rxe_dev *rxe, union ib_gid *mgid)
{ {
struct rxe_mcg *mcg, *tmp; struct rxe_mcg *mcg, *tmp;
unsigned long flags;
int err; int err;
if (rxe->attr.max_mcast_grp == 0) if (rxe->attr.max_mcast_grp == 0)
@ -211,18 +209,18 @@ static struct rxe_mcg *rxe_get_mcg(struct rxe_dev *rxe, union ib_gid *mgid)
if (!mcg) if (!mcg)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
spin_lock_irqsave(&rxe->mcg_lock, flags); spin_lock_bh(&rxe->mcg_lock);
/* re-check to see if someone else just added it */ /* re-check to see if someone else just added it */
tmp = __rxe_lookup_mcg(rxe, mgid); tmp = __rxe_lookup_mcg(rxe, mgid);
if (tmp) { if (tmp) {
spin_unlock_irqrestore(&rxe->mcg_lock, flags); spin_unlock_bh(&rxe->mcg_lock);
atomic_dec(&rxe->mcg_num); atomic_dec(&rxe->mcg_num);
kfree(mcg); kfree(mcg);
return tmp; return tmp;
} }
__rxe_init_mcg(rxe, mgid, mcg); __rxe_init_mcg(rxe, mgid, mcg);
spin_unlock_irqrestore(&rxe->mcg_lock, flags); spin_unlock_bh(&rxe->mcg_lock);
/* add mcast address outside of lock */ /* add mcast address outside of lock */
err = rxe_mcast_add(rxe, mgid); err = rxe_mcast_add(rxe, mgid);
@ -272,14 +270,12 @@ static void __rxe_destroy_mcg(struct rxe_mcg *mcg)
*/ */
static void rxe_destroy_mcg(struct rxe_mcg *mcg) static void rxe_destroy_mcg(struct rxe_mcg *mcg)
{ {
unsigned long flags;
/* delete mcast address outside of lock */ /* delete mcast address outside of lock */
rxe_mcast_del(mcg->rxe, &mcg->mgid); rxe_mcast_del(mcg->rxe, &mcg->mgid);
spin_lock_irqsave(&mcg->rxe->mcg_lock, flags); spin_lock_bh(&mcg->rxe->mcg_lock);
__rxe_destroy_mcg(mcg); __rxe_destroy_mcg(mcg);
spin_unlock_irqrestore(&mcg->rxe->mcg_lock, flags); spin_unlock_bh(&mcg->rxe->mcg_lock);
} }
/** /**
@ -334,25 +330,24 @@ static int rxe_attach_mcg(struct rxe_mcg *mcg, struct rxe_qp *qp)
{ {
struct rxe_dev *rxe = mcg->rxe; struct rxe_dev *rxe = mcg->rxe;
struct rxe_mca *mca, *tmp; struct rxe_mca *mca, *tmp;
unsigned long flags;
int err; int err;
/* check to see if the qp is already a member of the group */ /* check to see if the qp is already a member of the group */
spin_lock_irqsave(&rxe->mcg_lock, flags); spin_lock_bh(&rxe->mcg_lock);
list_for_each_entry(mca, &mcg->qp_list, qp_list) { list_for_each_entry(mca, &mcg->qp_list, qp_list) {
if (mca->qp == qp) { if (mca->qp == qp) {
spin_unlock_irqrestore(&rxe->mcg_lock, flags); spin_unlock_bh(&rxe->mcg_lock);
return 0; return 0;
} }
} }
spin_unlock_irqrestore(&rxe->mcg_lock, flags); spin_unlock_bh(&rxe->mcg_lock);
/* speculative alloc new mca without using GFP_ATOMIC */ /* speculative alloc new mca without using GFP_ATOMIC */
mca = kzalloc(sizeof(*mca), GFP_KERNEL); mca = kzalloc(sizeof(*mca), GFP_KERNEL);
if (!mca) if (!mca)
return -ENOMEM; return -ENOMEM;
spin_lock_irqsave(&rxe->mcg_lock, flags); spin_lock_bh(&rxe->mcg_lock);
/* re-check to see if someone else just attached qp */ /* re-check to see if someone else just attached qp */
list_for_each_entry(tmp, &mcg->qp_list, qp_list) { list_for_each_entry(tmp, &mcg->qp_list, qp_list) {
if (tmp->qp == qp) { if (tmp->qp == qp) {
@ -366,7 +361,7 @@ static int rxe_attach_mcg(struct rxe_mcg *mcg, struct rxe_qp *qp)
if (err) if (err)
kfree(mca); kfree(mca);
out: out:
spin_unlock_irqrestore(&rxe->mcg_lock, flags); spin_unlock_bh(&rxe->mcg_lock);
return err; return err;
} }
@ -400,9 +395,8 @@ static int rxe_detach_mcg(struct rxe_mcg *mcg, struct rxe_qp *qp)
{ {
struct rxe_dev *rxe = mcg->rxe; struct rxe_dev *rxe = mcg->rxe;
struct rxe_mca *mca, *tmp; struct rxe_mca *mca, *tmp;
unsigned long flags;
spin_lock_irqsave(&rxe->mcg_lock, flags); spin_lock_bh(&rxe->mcg_lock);
list_for_each_entry_safe(mca, tmp, &mcg->qp_list, qp_list) { list_for_each_entry_safe(mca, tmp, &mcg->qp_list, qp_list) {
if (mca->qp == qp) { if (mca->qp == qp) {
__rxe_cleanup_mca(mca, mcg); __rxe_cleanup_mca(mca, mcg);
@ -416,13 +410,13 @@ static int rxe_detach_mcg(struct rxe_mcg *mcg, struct rxe_qp *qp)
if (atomic_read(&mcg->qp_num) <= 0) if (atomic_read(&mcg->qp_num) <= 0)
__rxe_destroy_mcg(mcg); __rxe_destroy_mcg(mcg);
spin_unlock_irqrestore(&rxe->mcg_lock, flags); spin_unlock_bh(&rxe->mcg_lock);
return 0; return 0;
} }
} }
/* we didn't find the qp on the list */ /* we didn't find the qp on the list */
spin_unlock_irqrestore(&rxe->mcg_lock, flags); spin_unlock_bh(&rxe->mcg_lock);
return -EINVAL; return -EINVAL;
} }