iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pinctrl: at91-pio4: Use platform_get_irq() to get the interrupt

Browse Source 
platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

While at it, replace the dev_err() with dev_dbg() as platform_get_irq()
prints an error message upon error.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Tested-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20220104140913.29699-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Lad Prabhakar 2022-01-04 14:09:13 +00:00 committed by Linus Walleij
parent b9dc88de4d
commit c00cdc32e7
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
drivers/pinctrl/pinctrl-at91-pio4.c
View File

@ -1045,7 +1045,6 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
const char **group_names; const char **group_names;
const struct of_device_id *match; const struct of_device_id *match;
int i, ret; int i, ret;
struct resource *res;
struct atmel_pioctrl *atmel_pioctrl; struct atmel_pioctrl *atmel_pioctrl;
const struct atmel_pioctrl_data *atmel_pioctrl_data; const struct atmel_pioctrl_data *atmel_pioctrl_data;
@ -1164,16 +1163,15 @@ static int atmel_pinctrl_probe(struct platform_device *pdev)
/* There is one controller but each bank has its own irq line. */ /* There is one controller but each bank has its own irq line. */
for (i = 0; i < atmel_pioctrl->nbanks; i++) { for (i = 0; i < atmel_pioctrl->nbanks; i++) {
res = platform_get_resource(pdev, IORESOURCE_IRQ, i); ret = platform_get_irq(pdev, i);
if (!res) { if (ret < 0) {
dev_err(dev, "missing irq resource for group %c\n", dev_dbg(dev, "missing irq resource for group %c\n",
'A' + i); 'A' + i);
return -EINVAL; return ret;
} }
atmel_pioctrl->irqs[i] = res->start; atmel_pioctrl->irqs[i] = ret;
irq_set_chained_handler_and_data(res->start, irq_set_chained_handler_and_data(ret, atmel_gpio_irq_handler, atmel_pioctrl);
atmel_gpio_irq_handler, atmel_pioctrl); dev_dbg(dev, "bank %i: irq=%d\n", i, ret);
dev_dbg(dev, "bank %i: irq=%pr\n", i, res);
} }
atmel_pioctrl->irq_domain = irq_domain_add_linear(dev->of_node, atmel_pioctrl->irq_domain = irq_domain_add_linear(dev->of_node,