iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: osd_uld: Check scsi_device_get() return value

Browse Source 
scsi_device_get() can fail. Hence check its return value.

Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Acked-by: Boaz Harrosh <ooo@electrozaur.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bart Van Assche 2017-03-30 17:17:17 +00:00 committed by Martin K. Petersen
parent 8690218a4c
commit c02465fa13
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/scsi/osd/osd_uld.c
View File

@ -464,14 +464,15 @@ static int osd_probe(struct device *dev)
/* hold one more reference to the scsi_device that will get released /* hold one more reference to the scsi_device that will get released
* in __release, in case a logout is happening while fs is mounted * in __release, in case a logout is happening while fs is mounted
*/ */
scsi_device_get(scsi_device); if (scsi_device_get(scsi_device))
goto err_put_disk;
osd_dev_init(&oud->od, scsi_device); osd_dev_init(&oud->od, scsi_device);
/* Detect the OSD Version */ /* Detect the OSD Version */
error = __detect_osd(oud); error = __detect_osd(oud);
if (error) { if (error) {
OSD_ERR("osd detection failed, non-compatible OSD device\n"); OSD_ERR("osd detection failed, non-compatible OSD device\n");
goto err_put_disk; goto err_put_sdev;
} }
/* init the char-device for communication with user-mode */ /* init the char-device for communication with user-mode */
@ -508,8 +509,9 @@ static int osd_probe(struct device *dev)
err_put_cdev: err_put_cdev:
cdev_del(&oud->cdev); cdev_del(&oud->cdev);
err_put_disk: err_put_sdev:
scsi_device_put(scsi_device); scsi_device_put(scsi_device);
err_put_disk:
put_disk(disk); put_disk(disk);
err_free_osd: err_free_osd:
dev_set_drvdata(dev, NULL); dev_set_drvdata(dev, NULL);