iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

extcon: max77843: fix handling return value of regmap_irq_get_virq

Browse Source 
The function can return negative values, so its result should
be assigned to signed variable.

The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
This commit is contained in:
Andrzej Hajda 2015-12-14 11:06:03 +01:00 committed by Chanwoo Choi
parent cbc46603df
commit c05c0d544e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/extcon/extcon-max77843.c
View File

@ -811,7 +811,7 @@ static int max77843_muic_probe(struct platform_device *pdev)
for (i = 0; i < ARRAY_SIZE(max77843_muic_irqs); i++) { for (i = 0; i < ARRAY_SIZE(max77843_muic_irqs); i++) {
struct max77843_muic_irq *muic_irq = &max77843_muic_irqs[i]; struct max77843_muic_irq *muic_irq = &max77843_muic_irqs[i];
unsigned int virq = 0; int virq = 0;
virq = regmap_irq_get_virq(max77843->irq_data_muic, virq = regmap_irq_get_virq(max77843->irq_data_muic,
muic_irq->irq); muic_irq->irq);