iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: ddbridge: detach first input if the second one failed to init

Browse Source 
In ddb_ports_attach(), if the second input of a dual tuner failed to
initialise, the first one can be detached (and resources be freed) as
this will be counted as the whole port having failed to initialise,
thus the first one won't be used anyway.

Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Daniel Scheller 2017-12-17 10:40:48 -05:00 committed by Mauro Carvalho Chehab
parent b7b9a5a93b
commit c0e10260cc
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/pci/ddbridge/ddbridge-core.c
View File

@ -1935,8 +1935,10 @@ static int ddb_port_attach(struct ddb_port *port)
if (ret < 0)
break;
ret = dvb_input_attach(port->input[1]);
if (ret < 0)
if (ret < 0) {
dvb_input_detach(port->input[0]);
break;
}
port->input[0]->redi = port->input[0];
port->input[1]->redi = port->input[1];
break;