iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: kobil: fix memory leak

Browse Source 
An urb transfer buffer is allocated at every open but was never freed.

This driver is a bit of a mess...

Cc: stable <stable@kernel.org>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Johan Hovold 2010-05-15 17:53:43 +02:00 committed by Greg Kroah-Hartman
parent 86234d4975
commit c0f631d194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/usb/serial/kobil_sct.c
View File

@ -345,7 +345,8 @@ static void kobil_close(struct usb_serial_port *port)
/* FIXME: Add rts/dtr methods */ /* FIXME: Add rts/dtr methods */
if (port->write_urb) { if (port->write_urb) {
usb_kill_urb(port->write_urb); usb_poison_urb(port->write_urb);
kfree(port->write_urb->transfer_buffer);
usb_free_urb(port->write_urb); usb_free_urb(port->write_urb);
port->write_urb = NULL; port->write_urb = NULL;
} }