iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fbmon: prevent division by zero in fb_videomode_from_videomode()

Browse Source 
The expression htotal * vtotal can have a zero value on
overflow. It is necessary to prevent division by zero like in
fb_var_to_videomode().

Found by Linux Verification Center (linuxtesting.org) with Svace.

Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Helge Deller <deller@gmx.de>
This commit is contained in:
Roman Smirnov 2024-03-19 11:13:44 +03:00 committed by Helge Deller
parent 152609795d
commit c2d953276b
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/video/fbdev/core/fbmon.c
View File

@ -1311,7 +1311,7 @@ int fb_get_mode(int flags, u32 val, struct fb_var_screeninfo *var, struct fb_inf
int fb_videomode_from_videomode(const struct videomode *vm, int fb_videomode_from_videomode(const struct videomode *vm,
struct fb_videomode *fbmode) struct fb_videomode *fbmode)
{ {
unsigned int htotal, vtotal; unsigned int htotal, vtotal, total;
fbmode->xres = vm->hactive; fbmode->xres = vm->hactive;
fbmode->left_margin = vm->hback_porch; fbmode->left_margin = vm->hback_porch;
@ -1344,8 +1344,9 @@ int fb_videomode_from_videomode(const struct videomode *vm,
vtotal = vm->vactive + vm->vfront_porch + vm->vback_porch + vtotal = vm->vactive + vm->vfront_porch + vm->vback_porch +
vm->vsync_len; vm->vsync_len;
/* prevent division by zero */ /* prevent division by zero */
if (htotal && vtotal) { total = htotal * vtotal;
fbmode->refresh = vm->pixelclock / (htotal * vtotal); if (total) {
fbmode->refresh = vm->pixelclock / total;
/* a mode must have htotal and vtotal != 0 or it is invalid */ /* a mode must have htotal and vtotal != 0 or it is invalid */
} else { } else {
fbmode->refresh = 0; fbmode->refresh = 0;