iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RDMA/siw: Add missing rtnl_lock around access to ifa

Browse Source 
ifa is protected by rcu or rtnl, add the missing locking. In this case we
have to use rtnl since siw_listen_address() is sleeping.

Fixes: 6c52fdc244 ("rdma/siw: connection management")
Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
This commit is contained in:
Jason Gunthorpe 2019-07-11 11:29:42 -03:00
parent 775a41e281
commit c421651fa2
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/infiniband/sw/siw/siw_cm.c
View File

@ -1975,6 +1975,7 @@ int siw_create_listen(struct iw_cm_id *id, int backlog)
id, &s_laddr.sin_addr, ntohs(s_laddr.sin_port), id, &s_laddr.sin_addr, ntohs(s_laddr.sin_port),
&s_raddr->sin_addr, ntohs(s_raddr->sin_port)); &s_raddr->sin_addr, ntohs(s_raddr->sin_port));
rtnl_lock();
for_ifa(in_dev) for_ifa(in_dev)
{ {
if (ipv4_is_zeronet(s_laddr.sin_addr.s_addr) || if (ipv4_is_zeronet(s_laddr.sin_addr.s_addr) ||
@ -1989,6 +1990,7 @@ int siw_create_listen(struct iw_cm_id *id, int backlog)
} }
} }
endfor_ifa(in_dev); endfor_ifa(in_dev);
rtnl_unlock();
in_dev_put(in_dev); in_dev_put(in_dev);
} else if (id->local_addr.ss_family == AF_INET6) { } else if (id->local_addr.ss_family == AF_INET6) {
struct inet6_dev *in6_dev = in6_dev_get(dev); struct inet6_dev *in6_dev = in6_dev_get(dev);