iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xfs: fix ->mknod() return value on xfs_get_acl() failure

Browse Source 
->mknod() should return negative on errors and PTR_ERR() gives
already negative value...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
This commit is contained in:
Al Viro 2011-06-05 11:12:31 +00:00 committed by Alex Elder
parent 59c5f46fbe
commit c46a131c0c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/xfs/linux-2.6/xfs_iops.c
View File

@ -182,7 +182,7 @@ xfs_vn_mknod(
if (IS_POSIXACL(dir)) { if (IS_POSIXACL(dir)) {
default_acl = xfs_get_acl(dir, ACL_TYPE_DEFAULT); default_acl = xfs_get_acl(dir, ACL_TYPE_DEFAULT);
if (IS_ERR(default_acl)) if (IS_ERR(default_acl))
return -PTR_ERR(default_acl); return PTR_ERR(default_acl);
if (!default_acl) if (!default_acl)
mode &= ~current_umask(); mode &= ~current_umask();