iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: musb: host: remove duplicate check in musb_ep_program()

Browse Source 
musb_ep_program() contains obviously duplicate check for 'dma_channel' in its
IN/receive path -- removing it allows to save one level of indentation. While
at it, improve the comment style...

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Sergei Shtylyov 2011-05-07 19:44:13 +04:00 committed by Felipe Balbi
parent 981430a170
commit c51e36dc11
1 changed files with 20 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
drivers/usb/musb/musb_host.c
View File

@ -837,33 +837,28 @@ static void musb_ep_program(struct musb *musb, u8 epnum,
/* kick things off */ /* kick things off */
if ((is_cppi_enabled() || tusb_dma_omap()) && dma_channel) { if ((is_cppi_enabled() || tusb_dma_omap()) && dma_channel) {
/* candidate for DMA */ /* Candidate for DMA */
if (dma_channel) { dma_channel->actual_len = 0L;
dma_channel->actual_len = 0L; qh->segsize = len;
qh->segsize = len;
/* AUTOREQ is in a DMA register */ /* AUTOREQ is in a DMA register */
musb_writew(hw_ep->regs, MUSB_RXCSR, csr); musb_writew(hw_ep->regs, MUSB_RXCSR, csr);
csr = musb_readw(hw_ep->regs, csr = musb_readw(hw_ep->regs, MUSB_RXCSR);
MUSB_RXCSR);
/* unless caller treats short rx transfers as /*
* errors, we dare not queue multiple transfers. * Unless caller treats short RX transfers as
*/ * errors, we dare not queue multiple transfers.
dma_ok = dma_controller->channel_program( */
dma_channel, packet_sz, dma_ok = dma_controller->channel_program(dma_channel,
!(urb->transfer_flags packet_sz, !(urb->transfer_flags &
& URB_SHORT_NOT_OK), URB_SHORT_NOT_OK),
urb->transfer_dma + offset, urb->transfer_dma + offset,
qh->segsize); qh->segsize);
if (!dma_ok) { if (!dma_ok) {
dma_controller->channel_release( dma_controller->channel_release(dma_channel);
dma_channel); hw_ep->rx_channel = dma_channel = NULL;
hw_ep->rx_channel = NULL; } else
dma_channel = NULL; csr |= MUSB_RXCSR_DMAENAB;
} else
csr |= MUSB_RXCSR_DMAENAB;
}
} }
csr |= MUSB_RXCSR_H_REQPKT; csr |= MUSB_RXCSR_H_REQPKT;