iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ethernet: manually convert memcpy(dev_addr,..., sizeof(addr))

Browse Source 
A handful of drivers use sizeof(addr) for the size of
the address, after manually confirming the size is
indeed 6 convert them to eth_hw_addr_set().

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Petko Manolov <petkan@nucleusys.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Jakub Kicinski 2021-10-13 13:44:32 -07:00
parent db0dcc6a8a
commit c51e5062c1
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/cadence/macb_main.c
View File

@ -313,7 +313,7 @@ static void macb_get_hwaddr(struct macb *bp)
addr[5] = (top >> 8) & 0xff; addr[5] = (top >> 8) & 0xff;
if (is_valid_ether_addr(addr)) { if (is_valid_ether_addr(addr)) {
memcpy(bp->dev->dev_addr, addr, sizeof(addr)); eth_hw_addr_set(bp->dev, addr);
return; return;
} }
} }

2
drivers/net/ethernet/dnet.c
View File

@ -93,7 +93,7 @@ static void dnet_get_hwaddr(struct dnet *bp)
*((__be16 *)(addr + 4)) = cpu_to_be16(tmp); *((__be16 *)(addr + 4)) = cpu_to_be16(tmp);
if (is_valid_ether_addr(addr)) if (is_valid_ether_addr(addr))
memcpy(bp->dev->dev_addr, addr, sizeof(addr)); eth_hw_addr_set(bp->dev, addr);
} }
static int dnet_mdio_read(struct mii_bus *bus, int mii_id, int regnum) static int dnet_mdio_read(struct mii_bus *bus, int mii_id, int regnum)

2
drivers/net/ethernet/pasemi/pasemi_mac.c
View File

@ -1722,7 +1722,7 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
err = -ENODEV; err = -ENODEV;
goto out; goto out;
} }
memcpy(dev->dev_addr, mac->mac_addr, sizeof(mac->mac_addr)); eth_hw_addr_set(dev, mac->mac_addr);
ret = mac_to_intf(mac); ret = mac_to_intf(mac);
if (ret < 0) { if (ret < 0) {

2
drivers/net/ethernet/ti/cpmac.c
View File

@ -1112,7 +1112,7 @@ static int cpmac_probe(struct platform_device *pdev)
priv->dev = dev; priv->dev = dev;
priv->ring_size = 64; priv->ring_size = 64;
priv->msg_enable = netif_msg_init(debug_level, 0xff); priv->msg_enable = netif_msg_init(debug_level, 0xff);
memcpy(dev->dev_addr, pdata->dev_addr, sizeof(pdata->dev_addr)); eth_hw_addr_set(dev, pdata->dev_addr);
snprintf(priv->phy_name, MII_BUS_ID_SIZE, PHY_ID_FMT, snprintf(priv->phy_name, MII_BUS_ID_SIZE, PHY_ID_FMT,
mdio_bus_id, phy_id); mdio_bus_id, phy_id);

2
drivers/net/usb/pegasus.c
View File

@ -357,7 +357,7 @@ static void set_ethernet_addr(pegasus_t *pegasus)
goto err; goto err;
} }
memcpy(pegasus->net->dev_addr, node_id, sizeof(node_id)); eth_hw_addr_set(pegasus->net, node_id);
return; return;
err: err: