iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ASoC: Intel: sst: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-94-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-03-15 16:06:25 +01:00 committed by Mark Brown
parent 0d31e8adf3
commit c524f1674f
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/soc/intel/atom/sst/sst_acpi.c
View File

@ -335,14 +335,13 @@ static int sst_acpi_probe(struct platform_device *pdev)
* This function is called by OS when a device is unloaded * This function is called by OS when a device is unloaded
* This frees the interrupt etc * This frees the interrupt etc
*/ */
static int sst_acpi_remove(struct platform_device *pdev) static void sst_acpi_remove(struct platform_device *pdev)
{ {
struct intel_sst_drv *ctx; struct intel_sst_drv *ctx;
ctx = platform_get_drvdata(pdev); ctx = platform_get_drvdata(pdev);
sst_context_cleanup(ctx); sst_context_cleanup(ctx);
platform_set_drvdata(pdev, NULL); platform_set_drvdata(pdev, NULL);
return 0;
} }
static const struct acpi_device_id sst_acpi_ids[] = { static const struct acpi_device_id sst_acpi_ids[] = {
@ -360,7 +359,7 @@ static struct platform_driver sst_acpi_driver = {
.pm = &intel_sst_pm, .pm = &intel_sst_pm,
}, },
.probe = sst_acpi_probe, .probe = sst_acpi_probe,
.remove = sst_acpi_remove, .remove_new = sst_acpi_remove,
}; };
module_platform_driver(sst_acpi_driver); module_platform_driver(sst_acpi_driver);