Revert "serial: core: only stop transmit when HW fifo is empty"
This reverts commit 7bfb915a597a301abb892f620fe5c283a9fdbd77. This commit broke pxa and omap-serial, because it inhibited them from calling stop_tx() if their TX FIFOs weren't completely empty. This resulted in these two drivers hanging during transmits because the TX interrupt would stay enabled, and a new TX interrupt would never fire. Cc: stable@vger.kernel.org Fixes: 7bfb915a597a ("serial: core: only stop transmit when HW fifo is empty") Signed-off-by: Doug Brown <doug@schmorgal.com> Link: https://lore.kernel.org/r/20240606195632.173255-2-doug@schmorgal.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
a81dbd0463
commit
c5603e2a62
@ -811,8 +811,7 @@ enum UART_TX_FLAGS {
|
||||
if (pending < WAKEUP_CHARS) { \
|
||||
uart_write_wakeup(__port); \
|
||||
\
|
||||
if (!((flags) & UART_TX_NOSTOP) && pending == 0 && \
|
||||
__port->ops->tx_empty(__port)) \
|
||||
if (!((flags) & UART_TX_NOSTOP) && pending == 0) \
|
||||
__port->ops->stop_tx(__port); \
|
||||
} \
|
||||
\
|
||||
|
Loading…
x
Reference in New Issue
Block a user