iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[libata] sata_nv: s/spin_lock_irqsave/spin_lock/ in irq handler

Browse Source 
We don't need to use the heavier spin lock in the irq handler.

It's quite possible we can do this in nv_generic_interrupt() as well,
but I didn't take the time to pursue that train of thought.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Jeff Garzik 2006-06-20 05:08:44 -04:00
parent 5a44efff4f
commit c5fa46e175
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/scsi/sata_nv.c
View File

@ -371,14 +371,13 @@ static irqreturn_t nv_nf2_interrupt(int irq, void *dev_instance,
struct pt_regs *regs) struct pt_regs *regs)
{ {
struct ata_host_set *host_set = dev_instance; struct ata_host_set *host_set = dev_instance;
unsigned long flags;
u8 irq_stat; u8 irq_stat;
irqreturn_t ret; irqreturn_t ret;
spin_lock_irqsave(&host_set->lock, flags); spin_lock(&host_set->lock);
irq_stat = inb(host_set->ports[0]->ioaddr.scr_addr + NV_INT_STATUS); irq_stat = inb(host_set->ports[0]->ioaddr.scr_addr + NV_INT_STATUS);
ret = nv_do_interrupt(host_set, irq_stat); ret = nv_do_interrupt(host_set, irq_stat);
spin_unlock_irqrestore(&host_set->lock, flags); spin_unlock(&host_set->lock);
return ret; return ret;
} }
@ -387,14 +386,13 @@ static irqreturn_t nv_ck804_interrupt(int irq, void *dev_instance,
struct pt_regs *regs) struct pt_regs *regs)
{ {
struct ata_host_set *host_set = dev_instance; struct ata_host_set *host_set = dev_instance;
unsigned long flags;
u8 irq_stat; u8 irq_stat;
irqreturn_t ret; irqreturn_t ret;
spin_lock_irqsave(&host_set->lock, flags); spin_lock(&host_set->lock);
irq_stat = readb(host_set->mmio_base + NV_INT_STATUS_CK804); irq_stat = readb(host_set->mmio_base + NV_INT_STATUS_CK804);
ret = nv_do_interrupt(host_set, irq_stat); ret = nv_do_interrupt(host_set, irq_stat);
spin_unlock_irqrestore(&host_set->lock, flags); spin_unlock(&host_set->lock);
return ret; return ret;
} }